Skip to content

Change select/deselect all checkbox to buttons in Pull Members Up#49193

Merged
4 commits merged intodotnet:masterfrom
ryzngard:issues/794061_a11y_pull_members_up
Nov 6, 2020
Merged

Change select/deselect all checkbox to buttons in Pull Members Up#49193
4 commits merged intodotnet:masterfrom
ryzngard:issues/794061_a11y_pull_members_up

Conversation

@ryzngard
Copy link
Contributor

@ryzngard ryzngard commented Nov 5, 2020

Fixes AB#794061

This makes keyboard navigation more user friendly and fixes issues with cell navigation from Narrator when the header checkbox is focused.

New UI:

image

@ryzngard ryzngard added Area-IDE Tenet-User Friendly Accessibility-related functionality is broken (e.g. high-DPI, key mnemonics, screen reader, etc.) labels Nov 5, 2020
@ryzngard ryzngard requested a review from a team as a code owner November 5, 2020 20:45
@ryzngard ryzngard requested a review from JoeRobich November 5, 2020 22:49
@ghost
Copy link

ghost commented Nov 6, 2020

Hello @ryzngard!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@ghost ghost merged commit 7aab00b into dotnet:master Nov 6, 2020
@ghost ghost added this to the Next milestone Nov 6, 2020
@allisonchou allisonchou modified the milestones: Next, 16.9.P2 Nov 24, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-IDE auto-merge Tenet-User Friendly Accessibility-related functionality is broken (e.g. high-DPI, key mnemonics, screen reader, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants