Fix extract local function crash#49184
Merged
allisonchou merged 4 commits intodotnet:masterfrom Nov 5, 2020
Merged
Conversation
Contributor
Author
|
Whoops hold on, noticed something weird with the fix - will re-open when ready. |
CyrusNajmabadi
approved these changes
Nov 5, 2020
davidwengier
approved these changes
Nov 5, 2020
Member
davidwengier
left a comment
There was a problem hiding this comment.
A general question: Does this still generate the local function, and just show the message as information, or is this more of an error that says "We can't do anything: " ?
...ditorFeatures/DiagnosticsTestUtilities/CodeActions/AbstractCodeActionOrUserDiagnosticTest.cs
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #45422.
Extract local function always introduces a call to the newly extracted function. There are some cases when introducing this call is impossible (e.g. when the selection is solely a local function), and trying to extract these selections currently results in a crash. We should not offer extract local function in this case.