Closed
Conversation
RikkiGibson
reviewed
Nov 7, 2020
src/Tools/Source/RunTests/Options.cs
Outdated
| } | ||
|
|
||
| artifactsPath ??= TryGetArtifactsPath(); | ||
| dotnetFilePath ??= Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.ProgramFiles), @"dotnet\dotnet.exe"); |
Member
There was a problem hiding this comment.
If RunTests is started via dotnet CLI do we want to try and figure out where the dotnet that started RunTests is located instead of just looking in Program Files?
Member
Author
There was a problem hiding this comment.
Yes absotulely. That was on my "todo" list for this change. Given that we will always be using dotnet to invoke this tool (it won't have an app host) we can use this logic
Member
|
Perhaps this build failure is an instance of #47074 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #46930
The real gains of our build / test split won't be realized until we stop cloning the repository and restoring on the test jobs. Today much of the logic we have for test assembly discovery exists in our eng infrastructure, and some requires a restore to execute.
Attempting to simplify this by just moving the logic into RunTests. The goal being that all we need to run tests on the test jobs is RunTests (already there) + a really tiny powershell script that just feeds in the options based on the current leg.