Remove duplicated implementations of C# event hookup#49092
Merged
jasonmalinowski merged 1 commit intodotnet:masterfrom Nov 9, 2020
Merged
Remove duplicated implementations of C# event hookup#49092jasonmalinowski merged 1 commit intodotnet:masterfrom
jasonmalinowski merged 1 commit intodotnet:masterfrom
Conversation
be25f3d to
12fda77
Compare
CyrusNajmabadi
approved these changes
Nov 3, 2020
12fda77 to
f99e0af
Compare
davidwengier
approved these changes
Nov 4, 2020
Member
davidwengier
left a comment
There was a problem hiding this comment.
The first insertion into VS for Mac using EF.Cocoa from our repo is merged so we're good to start fixing issues.
Member
|
FYI @DavidKarlas @Therzok |
f99e0af to
df27c68
Compare
This feature originally existed in the C# editor layer, but then moved to the VS layer once we split out EditorFeatures.Wpf; we didn't have a CSharpEditorFeatures.Wpf so we had no place to put this since it had dependencies on WPF at the time. It no longer has a direct WPF dependency, so we can move this back to EditorFeatures and simply delete the Cocoa copy. The copy in EditorFeatures.Cocoa was verified to have no improvements against the current code; there were some differences but those were places where we made later fixes that hadn't been reflected into EditorFeatures.Cocoa. Fixes dotnet#34190
df27c68 to
bdf8701
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature originally existed in the C# editor layer, but then moved to the VS layer once we split out EditorFeatures.Wpf; we didn't have a CSharpEditorFeatures.Wpf so we had no place to put this since it had dependencies on WPF at the time. It no longer has a direct WPF dependency, so we can move this back to EditorFeatures and simply delete the Cocoa copy.
The copy in EditorFeatures.Cocoa was verified to have no improvements against the current code; there were some differences but those were places where we made later fixes that hadn't been reflected into EditorFeatures.Cocoa.
This will not be merged until @tmat and @davidwengier confirm we're good to take it.
Fixes #34190