Avoid realizing documents in DiagnosticDataSerializer#49081
Merged
sharwell merged 2 commits intodotnet:masterfrom Oct 31, 2020
Merged
Avoid realizing documents in DiagnosticDataSerializer#49081sharwell merged 2 commits intodotnet:masterfrom
sharwell merged 2 commits intodotnet:masterfrom
Conversation
ryzngard
approved these changes
Oct 30, 2020
CyrusNajmabadi
approved these changes
Oct 30, 2020
| var documentId = document != null | ||
| ? document.Id | ||
| : project.Documents.FirstOrDefault(d => d.FilePath == originalFile)?.Id; | ||
| : project.State.DocumentStates.FirstOrDefault(d => d.Value.FilePath == originalFile).Key; |
Member
There was a problem hiding this comment.
Why isn't this just calling Solution.GetDocumentIdsByFilePath()? Then we're not using internal implementation details, and it's also not O(n).
Member
There was a problem hiding this comment.
(we can still filter down to the IDs from the given project to avoid linked file issues)
Contributor
Author
There was a problem hiding this comment.
Why isn't this just calling Solution.GetDocumentIdsByFilePath
I had no idea it existed 😄
jasonmalinowski
approved these changes
Oct 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change gives a 25% performance improvement for a recent internal trace.