Skip to content

Port #43548 from master-vs-deps to master#48987

Merged
19 commits merged intodotnet:masterfrom
genlu:EnableImportCompletion
Oct 28, 2020
Merged

Port #43548 from master-vs-deps to master#48987
19 commits merged intodotnet:masterfrom
genlu:EnableImportCompletion

Conversation

@genlu
Copy link
Member

@genlu genlu commented Oct 28, 2020

Accidentally merge #43548 into master-vs-deps, this PR brings it to master

genlu added 19 commits October 9, 2020 14:05
@genlu
Perf improvements
127a1de
@genlu
Remove import completion experiment and enable it by default
bbd312b
@genlu
Merge remote-tracking branch 'dotnet/master' into EnableImportComplet…
0db127d 
…ion2
@genlu
Add timebox to unimport ext method completion
f713449
@genlu
Pool objects to reduce allocation
aa0de62
@genlu
Disable import completion by default
fad9d46
@genlu
Eliminate call to resize
1e66540
@genlu
Revert "Disable import completion by default"
06e9981 
This reverts commit fad9d46.
@genlu
Revert "Remove import completion experiment and enable it by default"
6b27a67 
This reverts commit bbd312b.
@genlu
Remove the text "experimental" from import completion option
6e8bbdd
@genlu
Fix test
79e34bf
@genlu
address review comments
cdbe5d3
@genlu
More resource pooling to reduce allocation
54107a6
@genlu
Make sure we free pooled resource
f5c0f64
@genlu
Add comment
e6172e4
@genlu
Remove unnecessary cancellation
08018a8
@genlu
Use IDisposable pattern
cf5e2be
@genlu
Fix resx
91cae8a
@genlu
don't reset capacity for pooled object
8ae23d3
@genlu genlu requested a review from a team as a code owner October 28, 2020 17:36
RikkiGibson
RikkiGibson approved these changes Oct 28, 2020
View reviewed changes
Copy link
Member

@RikkiGibson RikkiGibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

signing-off on a backport of code already reviewed+merged to master-vs-deps.

@ghost
Copy link

ghost commented Oct 28, 2020

Hello @genlu!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 12 minutes, a condition that will be fulfilled in about 6 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

ghost
ghost approved these changes Oct 28, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@jasonmalinowski
Copy link
Member

jasonmalinowski commented Oct 28, 2020

@genlu Rather than doing a backport by cherry-picking, it looks like we could just do an old-fashioned fast-forward push. There's nothing else in the branch that's problematic right now.

@genlu
Copy link
Member Author

genlu commented Oct 28, 2020

@RikkiGibson I guess we can do what Jason said?

@ghost ghost merged commit a13ee2c into dotnet:master Oct 28, 2020
@ghost ghost added this to the Next milestone Oct 28, 2020
@genlu genlu deleted the EnableImportCompletion branch October 28, 2020 21:02
@allisonchou allisonchou modified the milestones: Next, 16.9.P2 Nov 24, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RikkiGibson RikkiGibson RikkiGibson approved these changes

+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-IDE auto-merge

Projects

None yet

Milestone

16.9.P2

Development

Successfully merging this pull request may close these issues.

5 participants

@genlu @jasonmalinowski @RikkiGibson @allisonchou @Dotnet-GitSync-Bot