Skip to content

Remove old NavTo interface.#48939

Merged
12 commits merged intodotnet:masterfrom
CyrusNajmabadi:removeOldInterface
Oct 30, 2020
Merged

Remove old NavTo interface.#48939
12 commits merged intodotnet:masterfrom
CyrusNajmabadi:removeOldInterface

Conversation

@CyrusNajmabadi
Copy link
Contributor

Fixes #28343

@CyrusNajmabadi CyrusNajmabadi requested review from a team as code owners October 27, 2020 05:25
@CyrusNajmabadi CyrusNajmabadi requested a review from a team October 27, 2020 05:25
@CyrusNajmabadi
Copy link
Contributor Author

Tagging @DanielRosenwasser as this will affect TypeScript. This will not impact F# as they have an EA layer here.

@DanielRosenwasser
Copy link
Contributor

@DanielRosenwasser
Copy link
Contributor

Looks like we may be good here? #28343 (comment)

@CyrusNajmabadi
Copy link
Contributor Author

Right. But you'll have to move back to the nice, sane, name once i make this change :) Jusst giving you a heads-up, and also letting you block this on our end if you need more time.

@uniqueiniquity
Copy link
Contributor

@CyrusNajmabadi works for me, though please try to ensure this gets inserted earlier than the very end of a release cycle so we can respond without dealing with process overhead 😄

@CyrusNajmabadi
Copy link
Contributor Author

@sharwell any concerns here before i merge?

@sharwell
Copy link
Contributor

@CyrusNajmabadi if anything is referencing the interface with the long name, you can't rename it prior to those features moving the external access

@uniqueiniquity
Copy link
Contributor

Is there currently an external access version of this? I can go ahead and move us if that's the case.

@CyrusNajmabadi
Copy link
Contributor Author

I'll check. If there isn't, i can add it.

@sharwell
Copy link
Contributor

Is there currently an external access version of this?

Each partner team would need their own copy of the external access version.

@CyrusNajmabadi
Copy link
Contributor Author

@sharwell @uniqueiniquity ExternalAccess API added in e77231b

@CyrusNajmabadi
Copy link
Contributor Author

@sharwell i have added teh bridge type back in. can you ptal.

@ghost
Copy link

ghost commented Oct 30, 2020

Hello @CyrusNajmabadi!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@ghost ghost merged commit ff1dcc8 into dotnet:master Oct 30, 2020
@ghost ghost added this to the Next milestone Oct 30, 2020
@CyrusNajmabadi CyrusNajmabadi deleted the removeOldInterface branch October 30, 2020 18:07
@CyrusNajmabadi
Copy link
Contributor Author

@uniqueiniquity once this merges into master, can you move onto the TS EA layer? thanks!

@allisonchou allisonchou modified the milestones: Next, 16.9.P2 Nov 24, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove/replace INavigateToSearchService

7 participants