Skip to content

Switch the inline-hints shortcut from ctrl-alt to alt-f1#48887

Merged
1 commit merged intodotnet:masterfrom
CyrusNajmabadi:inlineHintShortcut
Oct 23, 2020
Merged

Switch the inline-hints shortcut from ctrl-alt to alt-f1#48887
1 commit merged intodotnet:masterfrom
CyrusNajmabadi:inlineHintShortcut

Conversation

@CyrusNajmabadi
Copy link
Contributor

ctrl-alt has the issue that it's the shortcut for 'create and insert multiple carets'. Switching to a shortcut that doesn't seem to be taken for any existing features.

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner October 23, 2020 19:48
@CyrusNajmabadi CyrusNajmabadi requested a review from a team October 23, 2020 19:48
@CyrusNajmabadi
Copy link
Contributor Author

fyi @DanielRosenwasser @cartermp

@ghost
Copy link

ghost commented Oct 23, 2020

Hello @CyrusNajmabadi!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@dibarbet
Copy link
Member

I don't have F row keys on my keyboard :(
Is it at all possible to make this an editor command where I can change the shortcut like other commands (e.g. gotodef)

@cartermp
Copy link
Contributor

oof, this is rough. I guess one of the issues is that the f-keys are okay for things that just need to be hit once (e.g., f12, shift-f12, alt-f12) rather than held to see a result. Are there other examples of holding a key command that involve f-keys?

@CyrusNajmabadi
Copy link
Contributor Author

I don't have F row keys on my keyboard :(

Wat...

Pix? How on earth do you use VS?? It's like half of hte keys i use.

Are there other examples of holding a key command that involve f-keys?

Nope. We're in a brave new world. But we have ot have something that doesn't literally break some other feature. ctrl-alt is taken :(

Is it at all possible to make this an editor command where I can change the shortcut like other commands (e.g. gotodef)

A problem here is that this isn't really a command that comes through, it's a chord held down.

@dibarbet
Copy link
Member

dibarbet commented Oct 23, 2020

Pix? How on earth do you use VS?? It's like half of hte keys i use.

My board needs a little cleanup before I take a picture, but this is the model - http://global.leopold.co.kr/Shop/Item.php?ItId=1524730041
I re-map bindings and generally use fewer shortcuts

A problem here is that this isn't really a command that comes through, it's a chord held down.

Hmm yeah I can't think of an example that allows remapping that isn't a command :(

@ghost ghost merged commit 6d4f588 into dotnet:master Oct 23, 2020
@ghost ghost added this to the Next milestone Oct 23, 2020
@allisonchou allisonchou modified the milestones: Next, 16.9.P2 Nov 24, 2020
@CyrusNajmabadi CyrusNajmabadi deleted the inlineHintShortcut branch April 11, 2021 18:23
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants