Use ISB-based API for retrieving solution assets in AssetSynchronizationSevice#48859
Merged
tmat merged 4 commits intodotnet:masterfrom Oct 23, 2020
Merged
Use ISB-based API for retrieving solution assets in AssetSynchronizationSevice#48859tmat merged 4 commits intodotnet:masterfrom
tmat merged 4 commits intodotnet:masterfrom
Conversation
Collaborator
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
cf2d869 to
1ab277f
Compare
c0f6e4a to
2422a81
Compare
sharwell
reviewed
Oct 22, 2020
...kspaces/Remote/ServiceHub/Services/AssetSynchronization/RemoteAssetSynchronizationService.cs
Show resolved
Hide resolved
sharwell
reviewed
Oct 22, 2020
sharwell
reviewed
Oct 22, 2020
...viceHub/Services/AsynchronousOperationListener/RemoteAsynchronousOperationListenerService.cs
Show resolved
Hide resolved
sharwell
approved these changes
Oct 22, 2020
Contributor
sharwell
left a comment
There was a problem hiding this comment.
- Would prefer more specific locations on the CS0618 suppressions instead of whole files
- Would prefer to not make code reordering changes to code that wasn't otherwise changing, especially since the original location was intentional
Member
Author
I'd prefer to remove inconsistency between these two services and the rest of the services. It's intentionally a "Refactoring" commit separate from the from the functional change. |
Contributor
|
@tmat this is not fixed in 16.9 Preview 1. Updating the milestone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plus a minor refactoring to align with other remote services:
Fixes AB#1223216
Fixes AB#1244894