Cleanup substring code#48834
Merged
CyrusNajmabadi merged 4 commits intodotnet:masterfrom Oct 23, 2020
Merged
Conversation
Collaborator
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
| builder.AddText(FeaturesResources.Awaited_task_returns_0.Substring(0, symbolIndex)); | ||
| builder.AddRange(mainDescriptionTaggedParts); | ||
| builder.AddText(FeaturesResources.Awaited_task_returns_0.Substring(symbolIndex + defaultSymbol.Length)); | ||
| builder.AddText(FeaturesResources.Awaited_task_returns_0[(symbolIndex + defaultSymbol).Length..]); |
Member
There was a problem hiding this comment.
Those parentheses are not right. Bug in the fixer, or manual change?
Contributor
Author
There was a problem hiding this comment.
manual. good catch. =-0
we've fixed this in the fixer. but i'm running an older version.
davidwengier
approved these changes
Oct 22, 2020
CyrusNajmabadi
commented
Oct 22, 2020
src/Features/Core/Portable/QuickInfo/CommonSemanticQuickInfoProvider.cs
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.