Delete the SolutionExplorerShim assembly and merge it into our VisualStudio.Implementation project#48831
Merged
jasonmalinowski merged 13 commits intodotnet:masterfrom Oct 23, 2020
Conversation
This comment has been minimized.
This comment has been minimized.
This method is public.
This was needed because we didn't want to load all of Roslyn if we were being loaded to apply to a project that was not C#/VB. That's no longer a concern now that we use AppliesToProject. This also cleans things up so we are able to use the same constructor for both the product and tests.
This was needed because we didn't want to load all of Roslyn if we were being loaded to apply to a project that was not C#/VB. That's no longer a concern now that we use AppliesToProject.
This was needed because we didn't want to load all of Roslyn if we were being loaded to apply to a project that was not C#/VB. That's no longer a concern now that we use AppliesToProject.
This was helping with the lazy redirection, and if this was hosted in non-Visual Studio editors. We'll remove it for now.
We have no need for a separate project now, so just move them back into another project. We choose to put it in our Implementation project, because LocalizableProperties is public for COM marshalling. Some namespace qualifications are changing because: 1. The namespace that contained the resources is implicitly changing since the RESX generates into the default namespace for the project. 2. We are now referencing Microsoft.VisualStudio.CodeAnalysis.Sdk.UI in the Implementation project which causes some collisions with the CodeAnalysis namespace of our own.
d1c1239 to
472d27f
Compare
Member
Author
|
I suspect @mavasani and @tmeschter will be happy to see this project and the lazy loading hacks going away. |
472d27f to
e0dede2
Compare
mavasani
approved these changes
Oct 22, 2020
Contributor
mavasani
left a comment
There was a problem hiding this comment.
Looks great! Glad to see this project going away...
Contributor
There was a problem hiding this comment.
Nit: Define a string constant given it is used more than once?
Member
Author
There was a problem hiding this comment.
I thought about it, but I wasn't sure anything would be really clearer than just seeing the literal expression. And even if somebody did have to change this, I imagine they'd have to re audit all of the other ones to see if they still made sense, so this isn't really a good case where a constant means you can change it in one place and not have to worry about bugs you introduced.
src/VisualStudio/Core/Impl/SolutionExplorer/DiagnosticItem/BaseDiagnosticItem.BrowseObject.cs
Outdated
Show resolved
Hide resolved
src/VisualStudio/Core/Impl/SolutionExplorer/DiagnosticItem/CpsDiagnosticItem.cs
Outdated
Show resolved
Hide resolved
bc58ee4 to
2eeee26
Compare
Easy to do while I'm here.
2eeee26 to
5e98436
Compare
…Explorer We don't need to OptProf train it anymore now that it doesn't exist.
24 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We add the Analyzers node and related nodes to the Solution Explorer via an API that was exposed via MEF. Because there was
no way to control which projects loaded us, we loaded always, even in solutions that didn't contain C# or VB. To limit the damage, we had a separate assembly that carefully avoided ever loading C# or VB unless we actually had a project around.
The shell has updated the Solution Explorer API to allow us to specify as MEF metadata which projects we should apply to. This allows us to only be created when necessary, which means we can delete the entire assembly and merge it back in. We can also delete a bunch of lazy loading hacks and generally clean all sorts of things up.
Commit at a time is highly recommended here.