AsynchronousOperationListener cleanup#48825
Open
jasonmalinowski wants to merge 4 commits intodotnet:mainfrom
Open
AsynchronousOperationListener cleanup#48825jasonmalinowski wants to merge 4 commits intodotnet:mainfrom
jasonmalinowski wants to merge 4 commits intodotnet:mainfrom
Conversation
Collaborator
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
jasonmalinowski
commented
Oct 21, 2020
src/Tools/ExternalAccess/Apex/IApexAsynchronousOperationListenerProviderAccessor.cs
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
sharwell
reviewed
Oct 21, 2020
src/Workspaces/Core/Portable/Shared/TestHooks/IAsynchronousOperationListenerProvider.cs
Outdated
Show resolved
Hide resolved
sharwell
reviewed
Oct 21, 2020
src/VisualStudio/Core/Test/ProjectSystemShim/VisualStudioRuleSetTests.vb
Outdated
Show resolved
Hide resolved
sharwell
approved these changes
Oct 21, 2020
This was only casting to the concrete type to call GetListener; the intent here is you can directly import the concrete type if you're a test and want to wait on things.
It does nothing different than the other method -- it's just a convenience method that takes a params array.
Nothing used this; the only caller on the Apex side of things also didn't use it it.
98961b2 to
76efe7c
Compare
Contributor
|
@jasonmalinowski this PR looks gtg. Do you want to move it forward? Thanks! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The general pattern that's expected for our code is you import IAsynchronousOperationListenerProvider if you want to say when async operations are happening (that gives you the limited API to reference operations), and if you are in tests you can import the concrete type to get everything. We also had some extension methods that were doing explicit casting from the interface to the concrete type that were working around this pattern, and implicitly hiding the fact that some code was dead.
Commit at a time recommended.