Annotate the rest of Workspace_Editor.cs#48822
Merged
jasonmalinowski merged 2 commits intodotnet:masterfrom Oct 23, 2020
Merged
Annotate the rest of Workspace_Editor.cs#48822jasonmalinowski merged 2 commits intodotnet:masterfrom
jasonmalinowski merged 2 commits intodotnet:masterfrom
Conversation
Collaborator
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
ccf8c77 to
7f8a9a4
Compare
This wasn't necessary: GetActiveContextProjectIdAndWatchHierarchies only returns an ProjectId from one of the ones it was given, and that is always a subset of the DocumentIds that we started with, so this could never have returned null.
7f8a9a4 to
f9b8edf
Compare
davidwengier
approved these changes
Oct 22, 2020
Member
davidwengier
left a comment
There was a problem hiding this comment.
Seems straight forward enough to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.