Simplify generate-constructor logic for delegated constructors.#48821
Merged
8 commits merged intodotnet:masterfrom Oct 22, 2020
Merged
Simplify generate-constructor logic for delegated constructors.#488218 commits merged intodotnet:masterfrom
8 commits merged intodotnet:masterfrom
Conversation
Collaborator
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
CyrusNajmabadi
commented
Oct 21, 2020
| Public Sub New(v1 As Boolean, v2 As Integer) | ||
| Me.v1 = v1 | ||
| Me.v2 = v2 | ||
| End Sub |
Contributor
Author
There was a problem hiding this comment.
honestly, i cannot even wrap my head around the old behavior. the user was generating a call to new ...(true, 1). how that could generate a constructor that took int, int is beyond me. We now sensibly generate bool, int.
davidwengier
approved these changes
Oct 21, 2020
Member
davidwengier
left a comment
There was a problem hiding this comment.
Well this is certainly easier to read :D
|
Hello @CyrusNajmabadi! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic here is just crazy complex. Replacing with something much simpler and easier to maintain.