Use arcade Microsoft.Net.Test.Sdk version#48817
Merged
jaredpar merged 1 commit intodotnet:masterfrom Oct 23, 2020
Merged
Conversation
Delete our pinning of the Microsoft.Net.Test.Sdk package and let it flow from arcade.
Member
|
What version currently gets pulled in by Arcade? Have you verified that new test failures in Test Explorer are not introduced by this change? |
Member
Author
16.6..1
No. I can run them if you like and file issues for anything that breaks. Even so I would still believe we should go forward with the PR. We are very far out of date here, and getting further. The CI / CD mechanism is how we judge test correctness today hence if there are failures in other systems they feel more like follow up issues than blocking. Unless of course it's catostrophic but that doesn't seem to be the case. |
RikkiGibson
approved these changes
Oct 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete our pinning of the Microsoft.Net.Test.Sdk package and let it flow
from arcade.