Restore retry on integration tests#48812
Conversation
The retry mechanism on integration tests is predicated on not having the `--html` option passed to RunTests. PR dotnet#48686 changed it to be unconditionally passed which ended up breaking retry. Undoing the unconditional passing of `--html` to fix retry.
sharwell
left a comment
There was a problem hiding this comment.
This change restores retry for ci builds (good), but also enables it for local builds that run integration tests (bad). The logic doesn't need to rely on --html but should still switch on the local/ci condition somehow.
|
At this point it's unclear to me what changed, but it seems clear to you. Can u please elaborate? Having the |
|
The retry logic knows how to merge XML files to produce what looks like a single complete passing test run.
It can't do the same for HTML results. Since it didn't seem necessary to automatically retry during local test runs, the easiest way to address this was skipping retry for local runs rather than implementing support for HTML result merging. |
|
I think having the retry be an implicit function of |
|
That absolutely works for me. |
|
Hello @jaredpar! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
Integration test appears to be a flaky failure. Hitting a lot of builds: five in last 24 hours. |
The retry mechanism on integration tests is predicated on not having the
--htmloption passed to RunTests. PR #48686 changed it to beunconditionally passed which ended up breaking retry. Undoing the
unconditional passing of
--htmlto fix retry.