Merged
Conversation
Add check disabling snippets in cloud scenario
davidwengier
approved these changes
Oct 21, 2020
dibarbet
reviewed
Oct 21, 2020
| AssertIsForeground(); | ||
|
|
||
| // Don't execute in cloud environment, should be handled by LSP | ||
| if (subjectBuffer.IsInCloudEnvironmentClientContext()) |
Member
There was a problem hiding this comment.
I think we should just move this check to AreSnippetsEnabled, that way it happens earlier and still covers all entry points
dibarbet
approved these changes
Oct 21, 2020
|
Hello @allisonchou! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possibly fixes snippet crash https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1231856. This bug only replicates in Nexus and not Liveshare. I was having a lot of trouble getting running RoslynDev hive on the Nexus client, so I thought it would be the most efficient to open this low-risk PR (since snippets shouldn't work yet in LSP anyway) and verify whether it fixes the problem once inserted into VS.