Remove inline tags when edits intersect them.#48792
Merged
4 commits merged intodotnet:masterfrom Oct 22, 2020
Merged
Conversation
Collaborator
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
| var hints = await service.GetInlineHintsAsync(document, snapshotSpan.Span.ToTextSpan(), cancellationToken).ConfigureAwait(false); | ||
| foreach (var hint in hints) | ||
| { | ||
| // If we don't have any text to actually show the user, then don't make a tag. |
Member
There was a problem hiding this comment.
What scenario is this helping?
Contributor
Author
There was a problem hiding this comment.
when you have an error type. i thought about filtering closer to the symbol. But i prefer at this level because it means all empty tags will be stripped out.
davidwengier
approved these changes
Oct 20, 2020
Member
davidwengier
left a comment
There was a problem hiding this comment.
Seems simple enough ¯\_(ツ)_/¯
|
Hello @CyrusNajmabadi! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.