Fix inline-temp not being offered in linked-files.#48693
Fix inline-temp not being offered in linked-files.#48693CyrusNajmabadi merged 2 commits intodotnet:masterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
7875ba7 to
deb35ae
Compare
deb35ae to
9991b46
Compare
| { | ||
| var referencedSymbol = CreateReferencedSymbol("Goo", 1); | ||
|
|
||
| Assert.Equal("Goo, 1 ref", referencedSymbol.GetTestAccessor().GetDebuggerDisplay()); |
There was a problem hiding this comment.
these testswere useless. 1. testing debugger display is not necessary. 2. it was doing this bizarre thing about ensuring that hte debugger display only accesses the name of a symbol. all entirely unnecessary.
| { | ||
| await VerifyAgainstWorkspaceDefinitionAsync(expectedText, newSolution, workspace.ExportProvider); | ||
| var newSolutionWithLinkedFiles = await newSolution.WithMergedLinkedFileChangesAsync(oldSolution); | ||
| await VerifyAgainstWorkspaceDefinitionAsync(expectedText, newSolutionWithLinkedFiles, workspace.ExportProvider); |
There was a problem hiding this comment.
Should this be opt-in in some way? I'm worried this will hide bad code which doesn't account for linked files, but the tests don't fail, or make bugs harder to fix by making it harder to make a failing test.
There was a problem hiding this comment.
i don't think so. We really want this. Code actions shouldn't need to update other parts of a linked file. They just update one, and the workspace does this. The primary issue here is htat we're not going through the workspace, so we don't get that behavior.
All this code goes away as we move more and more tests over to the roslyn-sdk (which does the right thing and goes through the workspace).
No description provided.