Avoid realizing the entire solution snapshot in the Sql layer.#48678
Avoid realizing the entire solution snapshot in the Sql layer.#486783 commits merged intodotnet:masterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
sharwell
left a comment
There was a problem hiding this comment.
Clever. Consider filing a follow-up issue to track optimizations in the public API surface since there is certainly some low-hanging fruit here.
Will do! |
|
Hello @CyrusNajmabadi! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
jasonmalinowski
left a comment
There was a problem hiding this comment.
Looks good, but I agree with @sharwell that we probably should track some work here. We already have a DocumentIds/ProjectIds collection exposed when you need just the IDs; it might be easy to make a DocumentAttributes or ProjectAttributes that exposes just the attributes but, and that we could do nearly allocation free.
Fixes #48597.
All the data we need is in the realized green snapshot tree. So we can just walk that instead of forcing the creation of the entire red tree.