Enable nullable reference types for shared utilities#48677
Merged
sharwell merged 1 commit intodotnet:masterfrom Oct 16, 2020
Merged
Enable nullable reference types for shared utilities#48677sharwell merged 1 commit intodotnet:masterfrom
sharwell merged 1 commit intodotnet:masterfrom
Conversation
CyrusNajmabadi
approved these changes
Oct 16, 2020
a4565e9 to
ebc147d
Compare
| subjectBuffer.Replace(result.Value.replacementSpan, result.Value.replacementText); | ||
|
|
||
| transaction.Complete(); | ||
| transaction?.Complete(); |
Member
There was a problem hiding this comment.
Yay, actual bugs being found!
Contributor
Author
There was a problem hiding this comment.
Not sure this was a bug in practice, but #48676 was found and fixed by this
jasonmalinowski
approved these changes
Oct 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #48676