Clarify the GetOutputFileName contract#48638
Merged
3 commits merged intodotnet:masterfrom Oct 26, 2020
Merged
Conversation
Member
Author
|
@roslyn-compiler PTAL |
cston
approved these changes
Oct 15, 2020
RikkiGibson
reviewed
Oct 16, 2020
RikkiGibson
approved these changes
Oct 16, 2020
|
Hello @jaredpar! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Member
|
@jaredpar fyi, this didn't merge. |
The `GetOutputFileName` consumption code requires the return to be non-null yet the implementation appeared to allow `null` returns. This change flips the return to be `string!` as well as reworking the code a bit to make the guarantees the compilers are providing much clearer
Co-authored-by: Rikki Gibson <rikkigibson@gmail.com>
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
GetOutputFileNameconsumption code requires the return to benon-null yet the implementation appeared to allow
nullreturns. Thischange flips the return to be
string!as well as reworking the code abit to make the guarantees the compilers are providing much clearer
closes #48599