Support running official build in dnceng#48614
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
6ec657b to
7861e0c
Compare
eng/build.ps1
Outdated
There was a problem hiding this comment.
changes in build script should only affect official build
eng/build.ps1
Outdated
There was a problem hiding this comment.
ConvertTo [](start = 11, length = 9)
This is suspicious: https://github.com/dotnet/platform-compat/blob/master/docs/DE0001.md
There was a problem hiding this comment.
Find-OptimizationInputsStoreForBranch only takes SecureString for PAT. That said, it'd be great if someone can confirm the way I handle the token here is OK
https://devdiv.visualstudio.com/Engineering/_git/Validation?path=%2Fsrc%2FOptimization%2FData.PowerShell%2FAuthenticatedCmdlet.cs&version=GBmain&line=51&lineEnd=52&lineStartColumn=1&lineEndColumn=1&lineStyle=plain
There was a problem hiding this comment.
@GrabYourPitchforks Should this be addressed in Find-OptimizationInputsStoreForBranch?
f44cca8 to
5878a7b
Compare
5878a7b to
d8f0c34
Compare
The pipeline in dnceng is here:
https://dev.azure.com/dnceng/internal/_build?definitionId=327&_a=summary
The build isn't fully functional yet because of missing credentials for publishing, but the build and signing all work:
https://dev.azure.com/dnceng/internal/_build/results?buildId=853881&view=results
I have tested existing pipeline in devdiv to confirm I didn't break anything:
With
SkipApplyOptimizationDataset to false:https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_build/results?buildId=4148443
With
SkipApplyOptimizationDataset to true:https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_build/results?buildId=4148449
I will make a follow-up PR to make sure two pipeline will produce build with different build number and assembly version.Update:
Added fix for differentiating build numbers from two pipelines. The behevaior is the build will start with regular build number which will be updated once the task is executed (first task in the yaml). Tested in dnceng (odd rev# for dnceng and even for devdiv)
https://dev.azure.com/dnceng/internal/_build/results?buildId=855163&view=logs&j=20fcf628-b65c-5865-625a-1cef81cda63b&t=20450ecf-f450-5022-55ce-fcecb22663e6
@MattGal @tmat @jaredpar @dotnet/roslyn-infrastructure Please take a look