Skip to content

Fix tests to work with 16.8 localization#48611

Merged
JoeRobich merged 5 commits intodotnet:release/dev16.8-vs-depsfrom
JoeRobich:loc-fix
Oct 19, 2020
Merged

Fix tests to work with 16.8 localization#48611
JoeRobich merged 5 commits intodotnet:release/dev16.8-vs-depsfrom
JoeRobich:loc-fix

Conversation

@JoeRobich
Copy link
Member

See changes in 41036e2 needed to work around differing punctuation translated strings.

/CC: @wli3

@JoeRobich JoeRobich requested review from a team as code owners October 14, 2020 23:28
@JoeRobich JoeRobich requested a review from a team October 14, 2020 23:28
@JoeRobich JoeRobich changed the base branch from master to release/dev16.8-vs-deps October 14, 2020 23:28
@JoeRobich JoeRobich mentioned this pull request Oct 14, 2020
Copy link
Contributor

@ryzngard ryzngard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve commit: 41036e2

@Cosifne
Copy link
Member

Cosifne commented Oct 15, 2020

QB has approved this for P6 so let's wait until next week to merge it.

@wli3
Copy link

wli3 commented Oct 16, 2020

@Cosifne @JoeRobich note you still need time for it to flow to SDK and VS

@JoeRobich JoeRobich merged commit 4c195c3 into dotnet:release/dev16.8-vs-deps Oct 19, 2020
@JoeRobich JoeRobich deleted the loc-fix branch March 14, 2025 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants