Fix property parsing when it contains parantheses#48598
Merged
AlekseyTs merged 11 commits intodotnet:masterfrom Nov 10, 2020
Merged
Fix property parsing when it contains parantheses#48598AlekseyTs merged 11 commits intodotnet:masterfrom
AlekseyTs merged 11 commits intodotnet:masterfrom
Conversation
Youssef1313
commented
Oct 14, 2020
333fred
reviewed
Oct 19, 2020
333fred
reviewed
Oct 22, 2020
src/Compilers/VisualBasic/Test/Syntax/Parser/ParserRegressionTests.vb
Outdated
Show resolved
Hide resolved
Youssef1313
commented
Oct 23, 2020
333fred
approved these changes
Oct 23, 2020
Member
333fred
left a comment
There was a problem hiding this comment.
LGTM with the redundant else removed.
Member
|
@dotnet/roslyn-compiler for a second review. |
AlekseyTs
reviewed
Oct 27, 2020
src/Compilers/VisualBasic/Test/Syntax/Parser/ParserRegressionTests.vb
Outdated
Show resolved
Hide resolved
AlekseyTs
reviewed
Oct 27, 2020
AlekseyTs
reviewed
Oct 27, 2020
Contributor
|
Done with review pass (iteration 3) |
Member
Author
|
@fred333 @AlekseyTs Can you give this another look? |
Contributor
|
@Youssef1313 It looks like |
333fred
reviewed
Nov 4, 2020
| Public ReadOnly Property NumberOfResult1() String Integer JohnDoe WwwIIWww Wow | ||
| Public ReadOnly Property NumberOfResult2() Some unexpected tokens As Integer | ||
|
|
||
| Public ReadOnly Property NumberOfResult3() ' With comment - no errors. |
Member
There was a problem hiding this comment.
Can you please also add a version with bad text in between the parens and the comment/line continuation below?
333fred
approved these changes
Nov 5, 2020
Contributor
|
@Youssef1313 Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #48587