Fix null-annotatation of ISerializerService.Deserialize#48577
Merged
jcouv merged 3 commits intodotnet:masterfrom Oct 17, 2020
Merged
Fix null-annotatation of ISerializerService.Deserialize#48577jcouv merged 3 commits intodotnet:masterfrom
jcouv merged 3 commits intodotnet:masterfrom
Conversation
Collaborator
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Member
Author
|
@jcouv PTAL |
sharwell
reviewed
Oct 14, 2020
sharwell
suggested changes
Oct 14, 2020
Contributor
sharwell
left a comment
There was a problem hiding this comment.
AssertNotNull constraint is expected.
sharwell
reviewed
Oct 14, 2020
sharwell
suggested changes
Oct 15, 2020
src/VisualStudio/Core/Test.Next/Remote/SerializationValidator.cs
Outdated
Show resolved
Hide resolved
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Utilities/Contract.cs
Outdated
Show resolved
Hide resolved
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Utilities/Contract.cs
Outdated
Show resolved
Hide resolved
sharwell
approved these changes
Oct 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
class?constraint fromAssertNotNullandContract.ThrowIfNullto allow checking for null on unconstrained generic value.