CI workarounds for 16.8 Preview 3#48484
Merged
sharwell merged 8 commits intodotnet:release/dev16.8from Oct 10, 2020
Merged
Conversation
jasonmalinowski
approved these changes
Oct 9, 2020
| // The _owner flag is cleared on Dispose. This should only occur when cancellation has already been | ||
| // requested, but at least in 16.8 Preview 3.0 it was not always the case. | ||
| cancellationToken.ThrowIfCancellationRequested(); | ||
| //Assumes.Present(provider); |
Member
There was a problem hiding this comment.
Just so we don't lose the request I had on the other PR: let's get a bug URL in the code pointing to this.
Comment on lines
+14
to
+17
| var stackTrace = new StackTrace(); | ||
| foreach (var frame in stackTrace.GetFrames()) | ||
| { | ||
| if (frame.GetMethod()?.DeclaringType?.FullName?.Contains("ChangedText") ?? false) |
Member
There was a problem hiding this comment.
This worries me more than just commenting out the assert...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.