Fix graph query for records#48451
Merged
jasonmalinowski merged 2 commits intodotnet:masterfrom Oct 12, 2020
Merged
Conversation
Youssef1313
commented
Oct 8, 2020
Youssef1313
commented
Oct 8, 2020
Comment on lines
+41
to
+42
| <Node Id="(@3 Type=R1)" Category="CodeSchema_Class" CodeSchemaProperty_IsInternal="True" CommonLabel="R1" Icon="Microsoft.VisualStudio.Class.Internal" Label="R1"/> | ||
| <Node Id="(@3 Type=R2)" Category="CodeSchema_Class" CodeSchemaProperty_IsInternal="True" CommonLabel="R2" Icon="Microsoft.VisualStudio.Class.Internal" Label="R2"/> |
Member
Author
There was a problem hiding this comment.
The records are currently classified as classes (i.e. shows with the same icon as classes) (See the following image):
This might be related to #48127
The icons seem to be internal (not in Roslyn repo), and I also think part of the implementation is internal too.
Member
jasonmalinowski
left a comment
There was a problem hiding this comment.
Good but let's revert the Roslyn.sln change.
CyrusNajmabadi
approved these changes
Oct 9, 2020
davidwengier
approved these changes
Oct 9, 2020
Member
|
Thanks @Youssef1313 for the fix! |
92 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #48449
Before:
After: