Skip to content

Make db lock static to investigate issue.#48394

Merged
1 commit merged intodotnet:masterfrom
CyrusNajmabadi:staticLock
Oct 13, 2020
Merged

Make db lock static to investigate issue.#48394
1 commit merged intodotnet:masterfrom
CyrusNajmabadi:staticLock

Conversation

@CyrusNajmabadi
Copy link
Contributor

@CyrusNajmabadi CyrusNajmabadi commented Oct 7, 2020

No description provided.

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner October 7, 2020 15:47
@sharwell sharwell marked this pull request as draft October 7, 2020 15:58
@sharwell
Copy link
Contributor

sharwell commented Oct 7, 2020

@CyrusNajmabadi Marked this as a draft for the investigation. Can you modify the implementation to force the use of the V2 provider (overriding the experiment and normal default)?

@CyrusNajmabadi CyrusNajmabadi mentioned this pull request Oct 7, 2020
Closed
@CyrusNajmabadi
Copy link
Contributor Author

CyrusNajmabadi commented Oct 7, 2020

Can you modify the implementation to force the use of the V2 provider (overriding the experiment and normal default)?

Done!

@CyrusNajmabadi CyrusNajmabadi force-pushed the staticLock branch 2 times, most recently from a158729 to 29afb46 Compare October 7, 2020 18:26
@CyrusNajmabadi
Copy link
Contributor Author

CyrusNajmabadi commented Oct 10, 2020

@sharwell do we want to take this (reverting the default-change portion of course)?

It's a very small change prior to hte larger refactoring you're proposing.

@CyrusNajmabadi CyrusNajmabadi marked this pull request as ready for review October 12, 2020 16:03
@CyrusNajmabadi
Copy link
Contributor Author

CyrusNajmabadi commented Oct 12, 2020

Marking as ready for review. I would like if we could take this simple change @sharwell. We can then take the composition change approach you're suggesting. That way, if we have to roll that back, we can rollback to this safe and simple change. Thanks!

sharwell
sharwell approved these changes Oct 12, 2020
View reviewed changes
Copy link
Contributor

@sharwell sharwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a generally safe change. Recommend squashing before or during merge to avoid 7 commits for the small change. 😄

@CyrusNajmabadi
Copy link
Contributor Author

CyrusNajmabadi commented Oct 12, 2020

Will squash on commit.

@CyrusNajmabadi CyrusNajmabadi force-pushed the staticLock branch 2 times, most recently from b91e6b2 to 9dec431 Compare October 12, 2020 16:52
@ghost
Copy link

ghost commented Oct 12, 2020

Hello @CyrusNajmabadi!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

ghost
ghost approved these changes Oct 12, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@sharwell
Copy link
Contributor

sharwell commented Oct 12, 2020

@CyrusNajmabadi A bunch of these appeared in the failed build. Probably not a bug from this pull request, but generally indicates a bug.

10/12/2020 18:54:11 Coordinated Universal Time: Error : 1 :[devenv:1504] Unexpected exception: StreamJsonRpc.RemoteInvocationException: Differences detected in solution checksum: assets only in the incremental solution but not in the request
VROhtD5PELooLfOUfRByOGlBIc0=, Microsoft.CodeAnalysis.Serialization.SolutionStateChecksums
uX5V7tpF70sDgeZIaVvYLCpi2tk=, Microsoft.CodeAnalysis.Options.SerializableOptionSet

assets only in new solution but not in incremental solution
Ah9ag+BOb7WXoQSsz92FvN0JnxE=, Microsoft.CodeAnalysis.Serialization.SolutionStateChecksums
YN6NcMTUSiEbgMYdkvdBPb+9iIM=, Microsoft.CodeAnalysis.Options.SerializableOptionSet

assets only in incremental solution but not in new solution
VROhtD5PELooLfOUfRByOGlBIc0=, Microsoft.CodeAnalysis.Serialization.SolutionStateChecksums
uX5V7tpF70sDgeZIaVvYLCpi2tk=, Microsoft.CodeAnalysis.Options.SerializableOptionSet

assets only in the request but not in incremental solution
Ah9ag+BOb7WXoQSsz92FvN0JnxE=, Microsoft.CodeAnalysis.Serialization.SolutionStateChecksums
YN6NcMTUSiEbgMYdkvdBPb+9iIM=, Microsoft.CodeAnalysis.Options.SerializableOptionSet



   at StreamJsonRpc.JsonRpc.<InvokeCoreAsync>d__133`1.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.ConfiguredValueTaskAwaitable`1.ConfiguredValueTaskAwaiter.GetResult()
   at Microsoft.CodeAnalysis.Remote.BrokeredServiceConnection`1.<TryInvokeAsync>d__10`1.MoveNext() in /_/src/Workspaces/Remote/Core/BrokeredServiceConnection.cs:line 114
RPC server exception:
System.InvalidOperationException: Differences detected in solution checksum: assets only in the incremental solution but not in the request
VROhtD5PELooLfOUfRByOGlBIc0=, Microsoft.CodeAnalysis.Serialization.SolutionStateChecksums
uX5V7tpF70sDgeZIaVvYLCpi2tk=, Microsoft.CodeAnalysis.Options.SerializableOptionSet

assets only in new solution but not in incremental solution
Ah9ag+BOb7WXoQSsz92FvN0JnxE=, Microsoft.CodeAnalysis.Serialization.SolutionStateChecksums
YN6NcMTUSiEbgMYdkvdBPb+9iIM=, Microsoft.CodeAnalysis.Options.SerializableOptionSet

assets only in incremental solution but not in new solution
VROhtD5PELooLfOUfRByOGlBIc0=, Microsoft.CodeAnalysis.Serialization.SolutionStateChecksums
uX5V7tpF70sDgeZIaVvYLCpi2tk=, Microsoft.CodeAnalysis.Options.SerializableOptionSet

assets only in the request but not in incremental solution
Ah9ag+BOb7WXoQSsz92FvN0JnxE=, Microsoft.CodeAnalysis.Serialization.SolutionStateChecksums
YN6NcMTUSiEbgMYdkvdBPb+9iIM=, Microsoft.CodeAnalysis.Options.SerializableOptionSet



      at Microsoft.CodeAnalysis.Remote.ThrowingTraceListener.Fail(String message, String detailMessage) in /_/src/Workspaces/Remote/ServiceHub/Services/Host/ThrowingTraceListener.cs:line 14
      at System.Diagnostics.TraceInternal.Fail(String message)
      at Microsoft.CodeAnalysis.Remote.TestUtils.<AssertChecksumsAsync>d__2.MoveNext() in /_/src/Workspaces/Remote/ServiceHub/Host/TestUtils.cs:line 79
   --- End of stack trace from previous location where exception was thrown ---
      at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
      at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
      at System.Runtime.CompilerServices.ConfiguredTaskAwaitable.ConfiguredTaskAwaiter.GetResult()
      at Microsoft.CodeAnalysis.Remote.RemoteWorkspace.SolutionCreator.<ValidateChecksumAsync>d__19.MoveNext() in /_/src/Workspaces/Remote/ServiceHub/Host/RemoteWorkspace.SolutionCreator.cs:line 525
   --- End of stack trace from previous location where exception was thrown ---
      at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
      at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
      at System.Runtime.CompilerServices.ConfiguredTaskAwaitable.ConfiguredTaskAwaiter.GetResult()
      at Microsoft.CodeAnalysis.Remote.RemoteWorkspace.SolutionCreator.<CreateSolutionAsync>d__6.MoveNext() in /_/src/Workspaces/Remote/ServiceHub/Host/RemoteWorkspace.SolutionCreator.cs:line 89
   --- End of stack trace from previous location where exception was thrown ---
      at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
      at Microsoft.VisualStudio.Telemetry.WindowsErrorReporting.WatsonReport.GetClrWatsonExceptionInfo(Exception exceptionObject)
   --- End of stack trace from previous location where exception was thrown ---
      at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
      at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
      at System.Runtime.CompilerServices.ConfiguredTaskAwaitable`1.ConfiguredTaskAwaiter.GetResult()
      at Microsoft.CodeAnalysis.Remote.RemoteWorkspace.<CreateSolution_NoLockAsync>d__10.MoveNext() in /_/src/Workspaces/Remote/ServiceHub/Host/RemoteWorkspace.cs:line 135
   --- End of stack trace from previous location where exception was thrown ---
      at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
      at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
      at System.Runtime.CompilerServices.ConfiguredTaskAwaitable`1.ConfiguredTaskAwaiter.GetResult()
      at Microsoft.CodeAnalysis.Remote.RemoteWorkspace.<GetSolutionAsync>d__12.MoveNext() in /_/src/Workspaces/Remote/ServiceHub/Host/RemoteWorkspace.cs:line 213
   --- End of stack trace from previous location where exception was thrown ---
      at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
      at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
      at System.Runtime.CompilerServices.ConfiguredTaskAwaitable`1.ConfiguredTaskAwaiter.GetResult()
      at Microsoft.CodeAnalysis.Remote.RemoteDocumentHighlightsService.<>c__DisplayClass2_0.<<GetDocumentHighlightsAsync>b__0>d.MoveNext() in /_/src/Workspaces/Remote/ServiceHub/Services/DocumentHighlights/RemoteDocumentHighlightsService.cs:line 40
   --- End of stack trace from previous location where exception was thrown ---
      at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
      at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
      at System.Runtime.CompilerServices.ConfiguredValueTaskAwaitable`1.ConfiguredValueTaskAwaiter.GetResult()
      at Microsoft.CodeAnalysis.Remote.BrokeredServiceBase.<RunServiceAsync>d__11`1.MoveNext() in /_/src/Workspaces/Remote/ServiceHub/Services/BrokeredServiceBase.cs:line 69

@ghost ghost merged commit b95f176 into dotnet:master Oct 13, 2020
@ghost ghost added this to the Next milestone Oct 13, 2020
@allisonchou allisonchou modified the milestones: Next, 16.9.P2 Nov 24, 2020
@CyrusNajmabadi CyrusNajmabadi deleted the staticLock branch April 11, 2021 18:23
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@sharwell sharwell sharwell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-IDE auto-merge

Projects

None yet

Milestone

16.9.P2

Development

Successfully merging this pull request may close these issues.

4 participants

@CyrusNajmabadi @sharwell @jinujoseph @allisonchou