Ensure that tokens are re-fetched to the position in the reset point in SyntaxParser.Reset#48393
Merged
jaredpar merged 3 commits intodotnet:release/dev16.8from Oct 9, 2020
Merged
Conversation
Contributor
Author
|
@dotnet/roslyn-compiler Please review a fix for a Watson bug. |
jcouv
reviewed
Oct 7, 2020
Member
There was a problem hiding this comment.
nit: consider adding a similar assertion in GetResetPoint
Contributor
Author
|
@dotnet/roslyn-compiler Please review a fix for a Watson bug, need a second sign-off. |
Contributor
Author
|
@dotnet/roslyn-ide, @dotnet/roslyn-infrastructure Are the failures of integration tests expected? |
6268a6f to
507e298
Compare
Contributor
Author
|
@dotnet/roslyn-compiler Please review a fix for a Watson bug, need a second sign-off. |
Contributor
Author
|
@cston Please review. |
jaredpar
approved these changes
Oct 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes AB#1179569.
Feedback ticket ID is 1224085