Make sure GlobalHubClientPackage is loaded#48343
Merged
1 commit merged intodotnet:masterfrom Oct 6, 2020
Merged
Conversation
89e254e to
6220d24
Compare
CyrusNajmabadi
approved these changes
Oct 6, 2020
Contributor
CyrusNajmabadi
left a comment
There was a problem hiding this comment.
i def prefer this, and am absolutely ok with this going in. It also seems worthwhile for us to continue the discussion with the ISB team to remove this UI dep themselves so their component can be entirely free threaded. (but that of course shouldn't block this PR) :)
src/VisualStudio/Core/Def/Implementation/Workspace/VisualStudioWorkspaceStatusServiceFactory.cs
Outdated
Show resolved
Hide resolved
src/VisualStudio/Core/Def/Implementation/Workspace/VisualStudioWorkspaceStatusServiceFactory.cs
Outdated
Show resolved
Hide resolved
IServiceBroker requires the UI thread to initialize a ServiceHub service if it is not already loaded before GetProxyAsync is called. This change loads GlobalHubClientPackage as part of WaitUntilFullyLoadedAsync to ensure this condition is met.
6220d24 to
59682c5
Compare
|
Hello @sharwell! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IServiceBrokerrequires the UI thread to initialize a ServiceHub service if it is not already loaded beforeGetProxyAsyncis called. This change loadsGlobalHubClientPackageas part ofWaitUntilFullyLoadedAsyncto ensure this condition is met.