Pass along option to diagnostic analyzer.#48333
Conversation
mavasani
left a comment
There was a problem hiding this comment.
Do we also want to pass configurable: false or we want the analyzer diagnostic to allow configurable code style option?
|
Hello @CyrusNajmabadi! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 12 minutes, a condition that will be fulfilled in about 6 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
i think it should follow that option. if the user disables the option, we'd want the hints to go away. etc. |
|
@CyrusNajmabadi there are test failures. |
Fixes #48327
THe
option: nullcode was added in 5b6cee9. I can't really understand why though. Absent a good reason for this, this analyzer should behave the same as the rest of our analyzers. @mavasani do you know why you did things this way in that PR?