Extend TypeDeclarationStructureTests with records#48161
Merged
CyrusNajmabadi merged 2 commits intodotnet:mainfrom Jun 3, 2022
Merged
Extend TypeDeclarationStructureTests with records#48161CyrusNajmabadi merged 2 commits intodotnet:mainfrom
CyrusNajmabadi merged 2 commits intodotnet:mainfrom
Conversation
| [InlineData("record")] | ||
| [InlineData("struct")] | ||
| [InlineData("interface")] | ||
| public async Task TestStruct3(string typeKind) |
Contributor
There was a problem hiding this comment.
i don't really even get how this test is working.
Member
Author
There was a problem hiding this comment.
I'm not sure too. Just extended it for records for completeness.
Member
Author
|
@CyrusNajmabadi Let me know if we should close this test-only change or merge it. It's a minor change, but I thought it's good to add to prevent any possible regression. |
Member
Author
|
Ping @CyrusNajmabadi for review. |
Contributor
|
Weird since it's a feature we aren't shipping. But it's tests, so i don't mind :) |
CyrusNajmabadi
approved these changes
Jun 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.