Skip to content

Decouple Workspace.Dispose#48068

Draft
sharwell wants to merge 5 commits intodotnet:mainfrom
sharwell:option-service-dispose
Draft

Decouple Workspace.Dispose#48068
sharwell wants to merge 5 commits intodotnet:mainfrom
sharwell:option-service-dispose

Conversation

@sharwell
Copy link
Contributor

@sharwell sharwell commented Sep 25, 2020

This pull request converts prior direct coupling to use the new IDisposable support from #47951.

  • Tie OptionService disposal to Workspace disposal
  • Tie IWorkspaceEventListenerService disposal to Workspace disposal

Fixes #56177

@CyrusNajmabadi
Copy link
Contributor

The pr blocking this went in. Please reactive this and get this in, or close out. thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Workspace disposal during MEF shutdown may try to create more stuff and throw exceptions

3 participants