Some more error list performance improvements#47848
Merged
mavasani merged 5 commits intodotnet:masterfrom Sep 19, 2020
Merged
Conversation
Contributor
mavasani
commented
Sep 18, 2020
- Make the error list build and live diagnostic de-duping cancellable: This ensures that repeated builds have fast error list refresh - currently, error list refresh for later builds will wait for all de-duping to complete for prior builds, just to throw away the computed results and re-refresh the error list.
- Link error list refresh operations to workspace's disposal token
- Eagerly initialize the saved project diagnostics from persistent storage after solution load to improve the error list refresh perf for the first build
1. Make the error list build and live diagnostic de-duping cancellable: This ensures that repeated builds have fast error list refresh - currently, error list refresh for later builds will wait for all de-duping to complete for prior builds, just to throw away the computed results and re-refresh the error list. 2. Link error list refresh operations to workspace's disposal token 3. Eagerly initialize the saved project diagnostics from persistent storage after solution load to improve the error list refresh perf for the first build
mavasani
commented
Sep 18, 2020
src/VisualStudio/Core/Def/Implementation/TaskList/ExternalErrorDiagnosticUpdateSource.cs
Outdated
Show resolved
Hide resolved
src/Features/Core/Portable/Diagnostics/DiagnosticAnalyzerService_BuildSynchronization.cs
Outdated
Show resolved
Hide resolved
src/VisualStudio/Core/Def/Implementation/TaskList/ExternalErrorDiagnosticUpdateSource.cs
Outdated
Show resolved
Hide resolved
src/VisualStudio/Core/Def/Implementation/TaskList/ExternalErrorDiagnosticUpdateSource.cs
Outdated
Show resolved
Hide resolved
src/VisualStudio/Core/Def/Implementation/TaskList/ExternalErrorDiagnosticUpdateSource.cs
Show resolved
Hide resolved
src/VisualStudio/Core/Def/Implementation/TaskList/ExternalErrorDiagnosticUpdateSource.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
Sep 18, 2020
mavasani
commented
Sep 18, 2020
src/VisualStudio/Core/Def/Implementation/TaskList/ExternalErrorDiagnosticUpdateSource.cs
Outdated
Show resolved
Hide resolved
…rDiagnosticUpdateSource.cs
|
Hello @mavasani! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
…into InitialLoadPerf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.