Fix issues with opening source generated files#47846
Merged
4 commits merged intodotnet:masterfrom Sep 19, 2020
Merged
Conversation
dibarbet
approved these changes
Sep 18, 2020
Member
There was a problem hiding this comment.
just want to check - the temp file could exist because it was already navigated to once, is that the scenario?
Member
Author
There was a problem hiding this comment.
@dibarbet Yes; if the file was already open we were still writing it a second time which triggered a reload.
davidwengier
approved these changes
Sep 18, 2020
If the file is already open, then this was causing us to trigger a reload prompt which we don't want.
This factory service was only being used to ensure there's a singleton across all workspaces, but that can be just as easily done by exporting it directly.
I passed the span to navigate to along to the service, and then never used it. Oops.
Source Generators always run now.
ae9bebc to
2ea0d2c
Compare
|
Hello @jasonmalinowski! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a smattering of small bugs; commit-by-commit is easiest.