Allow genearted local function parameter name to shadow variables#47844
Merged
4 commits merged intodotnet:masterfrom Sep 19, 2020
Merged
Allow genearted local function parameter name to shadow variables#478444 commits merged intodotnet:masterfrom
4 commits merged intodotnet:masterfrom
Conversation
...SharedUtilitiesAndExtensions/Workspace/CSharp/LanguageServices/CSharpSemanticFactsService.cs
Outdated
Show resolved
Hide resolved
jasonmalinowski
approved these changes
Sep 18, 2020
Member
jasonmalinowski
left a comment
There was a problem hiding this comment.
Looks good other than the spelling error @CyrusNajmabadi called out.
| await VerifyItemExistsAsync(markup, "db", glyph: (int)Glyph.Parameter); | ||
| await VerifyItemExistsAsync(markup, "context1", glyph: (int)Glyph.Parameter); | ||
|
|
||
| if (languageVersion.MapSpecifiedToEffectiveVersion() >= LanguageVersion.CSharp8) |
Member
There was a problem hiding this comment.
Thanks for testing with language names in both directions.
|
Hello @genlu! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Member
|
Thanks @genlu! :-) |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #42049
@dotnet/roslyn-ide
FYI @jcouv