Report warning for differences in parameter names in partial method declaration and implementation#47841
Report warning for differences in parameter names in partial method declaration and implementation#47841Youssef1313 wants to merge 1 commit intodotnet:mainfrom
Conversation
…eclaration and implementation
|
Thanks @Youssef1313. Please hold off on this for now until we confirm with C# Language Design that we want to warn for differences in parameter names. |
|
@Youssef1313, confirmed, we should warn for differences in parameter names or type parameter names. We should use the same warning used for type differences, WRN_PartialMethodTypeDifference, updated to mention names in addition to types. Perhaps the text of the combined warning should say: Please feel free to proceed after warning WRN_PartialMethodTypeDifference has been added to the 16.9 warning wave. |
|
@cston Thanks for confirming this. I'll wait until WRN_PartialMethodTypeDifference is added again, then update its message and add tests. In the meanwhile, I'll mark as a draft until WRN_PartialMethodTypeDifference is added again. |
|
@cston Any updates on this?
Looks like this had slipped from 16.9? |
|
Replaced by #53352 |
Fixes #47838