Don't warn on unused record primary constructor parameters#47830
Merged
davidwengier merged 1 commit intodotnet:masterfrom Sep 19, 2020
Merged
Conversation
mavasani
approved these changes
Sep 18, 2020
Youssef1313
reviewed
Sep 18, 2020
Member
Youssef1313
left a comment
There was a problem hiding this comment.
Does this completely avoid checking records?
The analyzer should report in some cases. See #47666
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #47142
Fixes #47174
Until we synthesize operation blocks for implicit code this analyzer can't reason about records much, so just opt them out and don't confuse/annoy people.
FYI @jcouv