Fix for issue 46942. VSIX suppressors do not run when Nuget analyzers / suppressors are installed.#47486
Merged
mavasani merged 6 commits intodotnet:masterfrom Sep 10, 2020
nschuessler:nschuessler/issue46942
Merged
Fix for issue 46942. VSIX suppressors do not run when Nuget analyzers / suppressors are installed.#47486mavasani merged 6 commits intodotnet:masterfrom nschuessler:nschuessler/issue46942
mavasani merged 6 commits intodotnet:masterfrom
nschuessler:nschuessler/issue46942
Conversation
kykwo
reviewed
Sep 8, 2020
src/Workspaces/Core/Portable/Diagnostics/SkippedHostAnalyzersInfo.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Sep 8, 2020
src/Workspaces/Core/Portable/Diagnostics/SkippedHostAnalyzersInfo.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Sep 8, 2020
src/Workspaces/Core/Portable/Diagnostics/SkippedHostAnalyzersInfo.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Sep 8, 2020
...torFeatures/CSharpTest/Diagnostics/DiagnosticAnalyzerDriver/DiagnosticAnalyzerDriverTests.cs
Show resolved
Hide resolved
mavasani
reviewed
Sep 8, 2020
...torFeatures/CSharpTest/Diagnostics/DiagnosticAnalyzerDriver/DiagnosticAnalyzerDriverTests.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Sep 8, 2020
...torFeatures/CSharpTest/Diagnostics/DiagnosticAnalyzerDriver/DiagnosticAnalyzerDriverTests.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Sep 8, 2020
Contributor
mavasani
left a comment
There was a problem hiding this comment.
Overall looks pretty good to me. Lets simplify further to only execute host suppressors if they have no overlap with any nuget suppressor/analyzer IDs.
Contributor
Author
|
@mavasani I'm not sure what is causing the CI failures above, it doesn't look like me unless my changes somehow affect integration testing. I have merged from |
mavasani
reviewed
Sep 9, 2020
mavasani
reviewed
Sep 9, 2020
Contributor
|
Tagging @dotnet/roslyn-compiler for test-only changes to |
cston
reviewed
Sep 9, 2020
...torFeatures/CSharpTest/Diagnostics/DiagnosticAnalyzerDriver/DiagnosticAnalyzerDriverTests.cs
Outdated
Show resolved
Hide resolved
cston
approved these changes
Sep 9, 2020
Contributor
cston
left a comment
There was a problem hiding this comment.
DiagnosticDescription changes LGTM.
|
Hello @mavasani! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix is to explicitly handle suppressors on the host and analyzer side, and allow them when they suppress a diagnostic not handled on the nuget installed side.
Mention @sharwell @mavasani @kykwo
Fixes issue 46942
Hoping to get this in 16.8 preview +