Fix nullable analysis of lambdas within conditional expressions#47405
Merged
RikkiGibson merged 4 commits intodotnet:masterfrom Sep 9, 2020
Merged
Fix nullable analysis of lambdas within conditional expressions#47405RikkiGibson merged 4 commits intodotnet:masterfrom
RikkiGibson merged 4 commits intodotnet:masterfrom
Conversation
333fred
reviewed
Sep 3, 2020
src/Compilers/CSharp/Test/Semantic/Semantics/NullableReferenceTypesTests.cs
Show resolved
Hide resolved
333fred
approved these changes
Sep 4, 2020
jaredpar
approved these changes
Sep 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #40561
For reasons I don't fully understand, analysis of conditional expressions is broken apart into phases, which can be seen in the implementation of
VisitConditionalOperatorCore. It seems like theconvertResultcalls at the end can end up visiting the lambda over again, and when we do this without threading in the appropriate state, we can get spurious warnings.Please review @333fred @dotnet/roslyn-compiler.