Trigger completion in 'new()' expression#47383
Merged
sharwell merged 8 commits intodotnet:masterfrom Sep 9, 2020
Merged
Conversation
| if (type is ITypeParameterSymbol typeParameterSymbol) | ||
| { | ||
| return Tuple.Create<ITypeSymbol, Location>(typeParameterSymbol.GetNamedTypeSymbolConstraint(), token.GetLocation()); | ||
| } |
Contributor
There was a problem hiding this comment.
this feels duplicative. i'd prefer we jsut return the type, and have a higher layer say what to do in teh case of a type-parameter. (this applies to the ObjCreation case above as well).
Member
Author
|
ping @CyrusNajmabadi I think this won't make it to 16.8? |
sharwell
reviewed
Sep 7, 2020
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/CSharp/Extensions/SyntaxNodeExtensions.cs
Outdated
Show resolved
Hide resolved
Member
Author
|
@sharwell do you have any other comments? |
Contributor
|
On vacation. Can wait until next week, or if @sharwell can look this week it could go forward. |
genlu
approved these changes
Sep 8, 2020
sharwell
approved these changes
Sep 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #46397
Fixes #47381