Skip to content

Revert "Revert "Merge pull request #46391 from CyrusNajmabadi/formPerf""#46548

Merged
RikkiGibson merged 1 commit intodotnet:master-vs-depsfrom
CyrusNajmabadi:revertRevert
Aug 7, 2020
Merged

Revert "Revert "Merge pull request #46391 from CyrusNajmabadi/formPerf""#46548
RikkiGibson merged 1 commit intodotnet:master-vs-depsfrom
CyrusNajmabadi:revertRevert

Conversation

@CyrusNajmabadi
Copy link
Contributor

This reverts commit f626ab2.

This is an attempt to go through RPS and determine where a regression is coming from.

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner August 4, 2020 22:33
@CyrusNajmabadi CyrusNajmabadi changed the base branch from master to master-vs-deps August 5, 2020 18:04
@CyrusNajmabadi
Copy link
Contributor Author

RPS succeeding here: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1165718/

@RikkiGibson this is ready to go in once it passes CI.

@RikkiGibson RikkiGibson merged commit 9078075 into dotnet:master-vs-deps Aug 7, 2020
@ghost ghost added this to the Next milestone Aug 7, 2020
@CyrusNajmabadi CyrusNajmabadi deleted the revertRevert branch August 7, 2020 16:35
@CyrusNajmabadi
Copy link
Contributor Author

Thanks!

@RikkiGibson
Copy link
Member

@CyrusNajmabadi I just noticed that this is a merge directly to master-vs-deps. Was that intentional? Is there any consequence to this change being in master-vs-deps but not master?

@RikkiGibson RikkiGibson modified the milestones: Next, 16.8.P2 Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants