Change build to support net5.0 TFs#46306
Merged
jaredpar merged 1 commit intodotnet:masterfrom Jul 28, 2020
Merged
Conversation
This updates our build to support the use of `net5.0` as a target framework inside of our repository. Note: this is back porting some changes from the covariant returns branch. Wanted to get them into master sooner so we get more exposure to them.
Member
Author
|
@dotnet/roslyn-infrastructure for review |
Member
Author
|
@dotnet/roslyn-infrastructure PTAL |
RikkiGibson
approved these changes
Jul 27, 2020
sharwell
approved these changes
Jul 27, 2020
333fred
reviewed
Jul 27, 2020
| This condition will be evaluated multiple times in multi-targeted projects hence need to be careful | ||
| to only set in the inner builds, not the outer build where only $(TargetFrameworks) is defined. | ||
| --> | ||
| <DisableNullableWarnings Condition="'$(DisableNullableWarnings)' == '' AND $(TargetFrameworks.Contains('netcoreapp3.1')) AND '$(TargetFramework)' != '' AND '$(TargetFramework)' != 'netcoreapp3.1'">true</DisableNullableWarnings> |
Member
There was a problem hiding this comment.
Oh man, this wasn't quoted before? That was a bug waiting to happen.
333fred
approved these changes
Jul 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates our build to support the use of
net5.0as a targetframework inside of our repository.
Note: this is back porting some changes from the covariant returns
branch. Wanted to get them into master sooner so we get more exposure to
them.