Remove wait for out of process start from OnLoadedAsync as it has not…#46219
Merged
dibarbet merged 1 commit intodotnet:masterfrom Jul 22, 2020
Merged
Remove wait for out of process start from OnLoadedAsync as it has not…#46219dibarbet merged 1 commit intodotnet:masterfrom
dibarbet merged 1 commit intodotnet:masterfrom
Conversation
… cancellation token. The wait will instead occur in ActivateAsync with cancellation
CyrusNajmabadi
approved these changes
Jul 22, 2020
genlu
approved these changes
Jul 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… cancellation token. The wait will instead occur in ActivateAsync with cancellation
Fixes - https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1148393
ILanguageClient.OnLoadedAsync does not have a cancellation token. So if VS is trying to shutdown while OnLoadedAsync is waiting for the OOP to start, then it will hang. So moving the wait here to ActivateAsync instead. This should have no functional impact on loading as ActivateAsync is called on completion OnLoadedAsync,but has a cancellation token.