Switch 'use auto prop' to use NRT and make us more null safe.#46194
Merged
CyrusNajmabadi merged 1 commit intodotnet:masterfrom Jul 22, 2020
Merged
Switch 'use auto prop' to use NRT and make us more null safe.#46194CyrusNajmabadi merged 1 commit intodotnet:masterfrom
CyrusNajmabadi merged 1 commit intodotnet:masterfrom
Conversation
sharwell
reviewed
Jul 21, 2020
Comment on lines
17
to
+21
| internal abstract class AbstractUseAutoPropertyAnalyzer< | ||
| TPropertyDeclaration, TFieldDeclaration, TVariableDeclarator, TExpression> : AbstractBuiltInCodeStyleDiagnosticAnalyzer | ||
| TPropertyDeclaration, | ||
| TFieldDeclaration, | ||
| TVariableDeclarator, | ||
| TExpression> : AbstractBuiltInCodeStyleDiagnosticAnalyzer |
Contributor
There was a problem hiding this comment.
This is rough. It would be more readable like this:
internal abstract class AbstractUseAutoPropertyAnalyzer<TPropertyDeclaration, TFieldDeclaration, TVariableDeclarator, TExpression>
: AbstractBuiltInCodeStyleDiagnosticAnalyzer
Contributor
Author
There was a problem hiding this comment.
wrapped type parameters are used a fair bit in the codebase.
Contributor
There was a problem hiding this comment.
I'm only referring to this location, which changed as part of this pull request from a more readable form to a less readable form. A simple revert of this change would be equally acceptable, if not preferred.
Contributor
|
Were you able to reproduce the failure in a test? |
Contributor
Author
|
i was not. this attemps to beef up our null handling here to either remove hte issue entirely, or allow us to pinpoint where the issue is happening. the report as is is too incomplete to do anythign with. |
davidwengier
approved these changes
Jul 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #46102