Do not execute RemoveUnnecessaryInlineSuppressions on generated code#46092
Merged
mavasani merged 1 commit intodotnet:masterfrom Jul 17, 2020
Merged
Do not execute RemoveUnnecessaryInlineSuppressions on generated code#46092mavasani merged 1 commit intodotnet:masterfrom
mavasani merged 1 commit intodotnet:masterfrom
Conversation
mavasani
commented
Jul 17, 2020
| position, includeSkipped, includeDirectives, includeDocumentationComments); | ||
| } | ||
|
|
||
| public static bool IsGeneratedCode(this SyntaxTree syntaxTree, AnalyzerOptions? analyzerOptions, ISyntaxFacts syntaxFacts, CancellationToken cancellationToken) |
Contributor
Author
There was a problem hiding this comment.
Existing code just moved down to shared analyzers layer.
sharwell
reviewed
Jul 17, 2020
| @@ -28,18 +28,8 @@ public async Task<bool> IsGeneratedCodeAsync(Document document, CancellationToke | |||
|
|
|||
| private static bool IsGeneratedCode(SyntaxTree syntaxTree, Document document, CancellationToken cancellationToken) | |||
Contributor
There was a problem hiding this comment.
❔ Can we inline this to avoid duplication?
Contributor
Author
There was a problem hiding this comment.
I am not sure I understood, what part of duplication is avoided by inlining? This is invoked at couple of places above.
jmarolf
approved these changes
Jul 17, 2020
sharwell
approved these changes
Jul 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #46075