Use ISpanMapper before sending cross file results to LSP#46078
Merged
dibarbet merged 2 commits intodotnet:masterfrom Jul 17, 2020
Merged
Use ISpanMapper before sending cross file results to LSP#46078dibarbet merged 2 commits intodotnet:masterfrom
dibarbet merged 2 commits intodotnet:masterfrom
Conversation
dibarbet
commented
Jul 17, 2020
Member
Author
There was a problem hiding this comment.
this is the main change
aa31872 to
0c4ed8c
Compare
JoeRobich
approved these changes
Jul 17, 2020
src/VisualStudio/LiveShare/Impl/AbstractGoToDefinitionWithFindUsagesServiceHandler.cs
Outdated
Show resolved
Hide resolved
…UsagesServiceHandler.cs Co-authored-by: Joey Robichaud <joseph.robichaud@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Razor is not able to intercept cross file requests made from the LSP client to C# files (these results could contain references to types in a razor file). So for cloud environments, we need to return the mapped paths to the LSP client so that these results can be displayed and navigated to.
This modifies the conversion helpers to map paths before converting to the LSP type and adds some tests.
Resolves #45063 for cloud environments (except rename).