Conversation
|
@jmarolf Do you find this PR title descriptive enough? |
|
@AlekseyTs I do :) gotta have some mystery in there to add human interest. |
|
also fixes #38357 |
|
Is there a measurable build time difference as a result of this change? Or does it just tend to affect the performance of incremental builds over a period of time? |
@RikkiGibson Since we always build with the bootstrap compiler I compared this CI build time to masters
|
| { | ||
| // Store 100 entries -- arbitrary number | ||
| private const int CacheSize = 100; | ||
| // Store 500 entries -- Out of ~8.7M projects, only about 4,000 had more than 500 references |
There was a problem hiding this comment.
This is really gonna kill my story telling abilities. Discussing how this number was chosen by a highly scientific process that in reality is just a number that made the least people scream was one of my favorites. Now I have to say it has some real logic behind it.
There was a problem hiding this comment.
But it does involve suggesting that we make it over 9000, so there's that
fixes #46023
fixes #38357
This updates the number of assemblies cached by the compiler server from 100 to 500. This number was chosen based on telemetry reporting. See linked issues for details.