Fix KeyNotFound exception in RemoveUnnecessaryInlineSuppressionsDiagn…#46048
Merged
mavasani merged 1 commit intodotnet:masterfrom Jul 16, 2020
Merged
Fix KeyNotFound exception in RemoveUnnecessaryInlineSuppressionsDiagn…#46048mavasani merged 1 commit intodotnet:masterfrom
mavasani merged 1 commit intodotnet:masterfrom
Conversation
…osticAnalyzer Fixes dotnet#46047 dotnet#45765 enhance this analyzer to support detecting unnecessary inline SuppressMessageAttribute suppressions. This led to a regression when processing idToPragmasMap for unhandled IDs, which is fixed by this change.
mavasani
commented
Jul 16, 2020
| [Theory, CombinatorialData] | ||
| public async Task TestDoNotRemoveUnsupportedDiagnosticSuppression(bool disable) | ||
| [WorkItem(46047, "https://github.com/dotnet/roslyn/issues/46047")] | ||
| public async Task TestDoNotRemoveUnsupportedDiagnosticSuppression(bool disable, TestKind testKind) |
Contributor
Author
There was a problem hiding this comment.
The exception was being hit for TestKind.SuppressMessageAttributes when there are no pragmas in input.
sharwell
approved these changes
Jul 16, 2020
Contributor
Author
|
Thanks @sharwell |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…osticAnalyzer
Fixes #46047
#45765 enhanced this analyzer to support detecting unnecessary inline SuppressMessageAttribute suppressions. This led to a regression when processing
idToPragmasMapfor unhandled IDs, which is fixed by this change.